Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - GCE L7 LB not picking up a custom readinessProbe URL #209

Closed
wants to merge 1 commit into from

Conversation

guidoiaquinti
Copy link
Contributor

@guidoiaquinti guidoiaquinti commented Dec 1, 2021

Description

This is a fix for a GCP specific issue. The GCE L7 LB is not picking up the custom readinessProbe configurations if a port is not specified in the deployment configuration.

For more info see:

In this PR we modify the deployment configuration to specify the port and we also re-enable k6 ingestion testing for the GCP e2e test (previously disabled due to this issue)

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@hazzadous
Copy link
Contributor

I going to close this to reduce the noise in this repo, if it's really important feel free to open again.

@hazzadous hazzadous closed this Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants