Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Friendly reminder that I'm way out of my depth with Helm charts.
Essentially, as part of the special migrations work, I'd like to bump Celery specs a bit.
There are 2 ways to do this:
Here I'm going with a CPU request bump as Celery will run n worker processes where n == n cores. Our default deployments seem to be giving us 2 cores, and adding an extra one ensures Celery can have the same throughput while we hijack a worker for special migrations.
I guess this is a breaking change? Maybe the replicas approach is better?
Just sparking discussion here. I'd rather have a sensible default than write on the release notes that people should bump celery replicas on upgrades.
Type of change
How has this been tested?
It hasn't
Checklist