Default CHOP namespace to the release namespace

[fuziontech]

fixes https://github.com/PostHog/charts-clickhouse/issues/75

[macobo]

Wouldn't this break some existing installations since clickhouseOperator would move?

A more sane way is changing the default value to be blank and using default .Values.clickhouseOperator.namespace .Release.namespace

In both cases, going strictly by semver this is a breaking change.

[fuziontech]

Wouldn't this break some existing installations since clickhouseOperator would move?

Only if they were installing this off label from our instructions would this be a problem. We have them install this in the posthog namespace in all of our instructions. Doing this now vs later would only make this transition cleaner and less painful.

A more sane way is changing the default value to be blank and using default .Values.clickhouseOperator.namespace .Release.namespace

I would say safe over sane to be more accurate. The correct syntax would be {{ .Values.clickhouseOperator.namespace | default .Release.namespace }}
https://helm.sh/docs/chart_template_guide/functions_and_pipelines/#using-the-default-function

In both cases, going strictly by semver this is a breaking change.

This would be breaking, but the remedy would be simply to have existing installations add .Values.clickhouseOperator.namespace back to their provided values.yaml file.

[tiina303]

keep it just as empty, so we have the description. I believe the default function still works then

[fuziontech]

perfect

[tiina303]

lets yes do the defaulting as Karl suggested (with pipes as that's much better way to use functions).

[tiina303]

I had a feeling the "" didn't work with default, so I tested it, found another typo. Namespace needs to be capitalized after release.

btw simple way to test this:

helm template posthog charts/posthog --set cloud="x" -n "blah" | grep "clickhouse_service_account" -A5

^ and look at what you see for the namespace