Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup downsampling plugin #1

Merged
merged 4 commits into from
May 4, 2021
Merged

setup downsampling plugin #1

merged 4 commits into from
May 4, 2021

Conversation

neilkakkar
Copy link
Collaborator

@neilkakkar neilkakkar commented May 4, 2021

Changes

Setting up Downsampling Plugin.

Need to get my head around how Node projects are setup and built, too many .* files which I don't yet understand.

Needed for PostHog/posthog#3365

...

Checklist

  • Tests for new code

Copy link
Contributor

@mariusandra mariusandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, looks good enough for me to get in and try to install

@mariusandra
Copy link
Contributor

some tests seem to be failing though...

@mariusandra
Copy link
Contributor

might be better to just remove them for the moment, we can test manually and add them back later

@neilkakkar neilkakkar marked this pull request as ready for review May 4, 2021 16:01
@mariusandra mariusandra merged commit 7660fd6 into main May 4, 2021
@mariusandra mariusandra deleted the setup branch May 4, 2021 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants