This repository has been archived by the owner on Nov 4, 2021. It is now read-only.
Make timeout errors more understandable inside workers #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariusandra
reviewed
Jun 7, 2021
Comment on lines
40
to
45
| status.info( | ||
| '🍿', | ||
| wasCachedAlready | ||
| ? `Refetched action ID ${actionId} (team ID ${teamId}) from DB` | ||
| : `Fetched new action ID ${actionId} (team ID ${teamId}) from DB` | ||
| ) |
There was a problem hiding this comment.
I think we should leave this in, but at a reduced debug level, which would only be shown with LogLevel.Debug so that normally there's no spam
There was a problem hiding this comment.
Sounds good to me
There was a problem hiding this comment.
Actually, involves adding debug to status, so I'll pull it out into a separate PR instead.
Twixes
approved these changes
Jun 8, 2021
fuziontech
pushed a commit
to PostHog/posthog
that referenced
this pull request
Oct 12, 2021
PostHog/plugin-server#465) * add caller to async function guard * add simple test * add transforms test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add a caller parameter to async guard
This will soon help make it easier to understand what's going on with errors like these: https://sentry.io/organizations/posthog/issues/2358370433/?project=5592816
... and what went wrong with Bigquery in PostHog/bigquery-plugin#9
Checklist