Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor root screen recording and do not mutate properties when calling capture and more bug fixing #74

Merged
merged 12 commits into from Jan 11, 2024

Conversation

marandaneto
Copy link
Member

@marandaneto marandaneto commented Jan 9, 2024

馃挕 Motivation and Context

Closes #66
Check the changelog for the other changes

馃挌 How did you test it?

馃摑 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@marandaneto marandaneto requested a review from a team January 9, 2024 15:21
@marandaneto marandaneto changed the title chore: refactor root screen recording and do not mutate properties when calling capture chore: refactor root screen recording and do not mutate properties when calling capture and more bug fixing Jan 10, 2024
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@marandaneto marandaneto merged commit 0575989 into main Jan 11, 2024
3 checks passed
@marandaneto marandaneto deleted the ref/screen-view-root-mutation branch January 11, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants