Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix passing optional values to the JS SDK #84

Merged
merged 3 commits into from
Feb 22, 2024
Merged

Fix passing optional values to the JS SDK #84

merged 3 commits into from
Feb 22, 2024

Conversation

marandaneto
Copy link
Member

💡 Motivation and Context

Closes #83

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@marandaneto marandaneto requested a review from a team February 22, 2024 08:36
marandaneto
marandaneto commented Feb 22, 2024
View reviewed changes
lib/src/posthog_flutter_web_handler.dart
if (screenName != null) {
properties['\$screen_name'] = screenName;
}
properties['\$screen_name'] = screenName;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screenName is a required field.

@marandaneto marandaneto mentioned this pull request Feb 22, 2024
Closed
pauldambra
pauldambra approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@marandaneto marandaneto merged commit e4a0b38 into main Feb 22, 2024
3 checks passed
@marandaneto marandaneto deleted the fix/optional-js-sdk branch February 22, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauldambra pauldambra pauldambra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

identify method throws exception on web
2 participants
@marandaneto @pauldambra