Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename export for node to PostHog #16

Merged
merged 4 commits into from
Aug 23, 2022
Merged

Rename export for node to PostHog #16

merged 4 commits into from
Aug 23, 2022

Conversation

mariusandra
Copy link
Collaborator

No more PostHogGlobal

Copy link
Collaborator

@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but didnt check locally

@neilkakkar
Copy link
Contributor

Tested locally: Works for cjs.

When a module though, we need to import {PostHog} from 'posthog-node'. I'm guessing something to do with default imports not existing for modules?

@mariusandra
Copy link
Collaborator Author

What if we just kill the default export? It's bad practice anyway, and people are willing to change code when they upgrade to a new major version like 2.0.

@neilkakkar
Copy link
Contributor

Sounds good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants