chore: React Native for macOS support #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daibhin
approved these changes
Jan 24, 2024
| export let posthog: PostHog | undefined; | ||
|
|
||
| export const posthogAsync: Promise<PostHog> = PostHog.initAsync( | ||
| 'phc_pQ70jJhZKHRvDIL5ruOErnPy6xiAiWCqlL4ayELj4X8', |
There was a problem hiding this comment.
Should we exclude this or change it to an env variable? Would not like the source to be polluted with data if people run the example
There was a problem hiding this comment.
it's just a sample project with a testing org, it's nice to see events coming through, otherwise every time I run the examples, I have to change the apiKey before, rolling back the changes, its working quite well on the other SDKs as well but its only me testing it anyway.
Co-authored-by: David Newell <d.newell1@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
React Native macOS support
https://github.com/microsoft/react-native-macos
I ran into the issue microsoft/react-native-macos#2053 which means all dependencies have to be installed, even if not used but it is dynamically imported via
require, could not find an easy fix, only happens on RN macOS target.Changes
Release info Sub-libraries affected
Bump level
Libraries affected
Changelog notes