Config Additions: session_recording, mask_all_element_attributes, mask_all_text

[yakkomajuri]

Changes

So I was operating on a few hours of sleep today and put through #207 which, while preventing rrweb from capturing input values as stated, it doesn't prevent PostHog from doing so, because..... we already don't. 🤦 I confused our approach with rrweb's and went ahead and censored element attributes instead.

Nevertheless, this PR now adds multiple config options:

• session_recording: an object containing a subset of rrweb options that we can expose to our users
• mask_all_text: Prevents us from capturing textContent as per @lharress's request (and this makes a lot of sense)
• mask_all_element_attributes: prevents autocapture from capturing any element attributes (apparently you'd need this too @lharress?)

Checklist

• Tests for new code (if applicable)
• TypeScript definitions (module.d.ts) updated and in sync with library exports (if applicable)

[lharress]

Thanks, I think you missed one?

posthog-js/src/autocapture.js

Line 35 in 7faa07b

if (usefulElements.indexOf(tag_name) > -1) props['$el_text'] = getSafeText(elem)

The second kinda works for us (insert sledgehammer scalpel analogy here) in that we have some custom attributes that don't fall within the input sensitivity check. The 3 options (exclude attributes, textContent and the built in input conservativeness) will definitely help us. Thanks!

[yakkomajuri]

Fixed, thanks a lot for keeping an eye on this!

@posthog-bot please add @lharress for ideas and test

[posthog-contributions-bot]

@yakkomajuri

I've put up a pull request to add @lharress! 🎉

[lharress]

Thanks for jumping on it so fast!

[macobo]

We currently lack any E2E testing for autocapture functionality (and this would have introduced a bug there) - how do you feel about extending the testcafe test for this?

[yakkomajuri]

Thanks! I have no time today but can hopefully find time to improve the tests tomorrow!

[yakkomajuri]

I've addressed everything except testcafe tests - can get to it on this PR or a later one.

cc @macobo

[macobo]

Might be worth getting in here, but would also be OK with merging as-is if you're confident in it. :)

[yakkomajuri]

Comment came before I had access to browserstack - I now do so I'll play around with it

[yakkomajuri]

Definitely happy to update/change this again, but I've now structured E2E tests in 3 parts, to "set the tone" for future tests:

• Custom events work
• Autocapture works (captures events and the right props)
• Config options correctly affect capture behavior