Reconcile Server and Client side configurations for session recording and autocapture #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilkakkar
commented
May 24, 2021
| @@ -91,6 +105,7 @@ describe('Event capture', () => { | |||
| cy.wait(50) | |||
| cy.get('[data-cy-custom-event-button]').click() | |||
| cy.phCaptures().should('deep.equal', ['$pageview', 'custom-event']) | |||
| cy.get('@consoleError').should('not.be.called') | |||
There was a problem hiding this comment.
I wonder if we should be doing this more extensively in our Cypress tests to figure out if something unknown is breaking down
mariusandra
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #228 and #231
...
Checklist