Fix sessionRecording bug #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgl
approved these changes
May 24, 2021
macobo
reviewed
May 25, 2021
| for (let url in requests) { | ||
| const { data, options } = requests[url] | ||
| for (let key in requests) { | ||
| const { url, data, options } = requests[key] |
There was a problem hiding this comment.
Interesting. There are tests under src/tests/request-queue.js - mind adding one or editing existing ones in a way which demonstrates the problem? E.g. how was enqueue called in this case?
There was a problem hiding this comment.
Sure thing, that was the first item for today!
It's kinda unfortunate: we had a similar test for poll that works, but didn't have one for unload.
neilkakkar
commented
May 25, 2021
| [{ event: '$identify', timestamp: 1_620_000_000 }], | ||
| { transport: 'sendbeacon' } | ||
| ) | ||
| expect(given.handlePollRequest).toHaveBeenCalledWith('/e', [{ event: 'zeta', timestamp: 1_640_000_000 }], { |
There was a problem hiding this comment.
with the old code, this would be called with ('sessionRecording', data, options)
macobo
approved these changes
May 25, 2021
|
Great detective work! Reminder: don't forget to set |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #183
What a rollercoaster! The
urlis just one of many possible values for the key in the request object, the other possible options being:batchKey, which, ofcourse, we set tosessionRecordingfor session recording! ( https://github.com/PostHog/posthog-js/blob/master/src/extensions/sessionrecording.js#L122 )The annoying bit was figuring out that it was this specific part of the request queue that was mangling things up.
...
Checklist