Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(typescript): convert library to typescript #425

Merged
merged 68 commits into from
Aug 1, 2022
Merged

chore(typescript): convert library to typescript #425

merged 68 commits into from
Aug 1, 2022

Conversation

mariusandra
Copy link
Collaborator

@mariusandra mariusandra commented Jul 12, 2022 •
edited by benjackwhite
Loading

Needs #428

Changes

  • Aiming to be a 100% compatible refactor with no changes to behaviour, and minimal changes to code

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • TypeScript definitions (module.d.ts) updated and in sync with library exports (if applicable)

mariusandra
mariusandra commented Jul 20, 2022
View reviewed changes
Copy link
Collaborator Author

@mariusandra mariusandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests pass! Other than TestCafe, which seems to be flakey in general. Sometimes one of the three tests fails. Sometimes it's Safari. Sometimes Chrome.

.github/workflows/integration.yml Show resolved Hide resolved
src/gdpr-utils.ts Show resolved Hide resolved
src/posthog-core.ts Show resolved Hide resolved
@mariusandra
Copy link
Collaborator Author

Testing locally, the new library seems to work well with posthog itself. So, ready for review 💪

@benjackwhite benjackwhite mentioned this pull request Jul 22, 2022
Merged
4 tasks
@benjackwhite benjackwhite mentioned this pull request Jul 26, 2022
Merged
@benjackwhite
Copy link
Collaborator

Testcafe is unhappy but it actually does work on each browser. Tested it locally with browserstack and it was fine

@benjackwhite benjackwhite merged commit cdf0063 into master Aug 1, 2022
@benjackwhite benjackwhite deleted the typescript branch August 1, 2022 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjackwhite benjackwhite Awaiting requested review from benjackwhite

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mariusandra @benjackwhite