Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send/create $session_id on $snapshot events #96

Merged
merged 3 commits into from Oct 21, 2020
Merged

Send/create $session_id on $snapshot events #96

merged 3 commits into from Oct 21, 2020

Commits on Oct 20, 2020

  1. Generate a session id on client 

    This will be used by the BE to aggregate recordings

nanoid package used adds ~1kb to the bundle.

(Current) semantics of session id:
- Two tabs will share the same session id
- Incognito/not incognito/different browser will not share session_id

This is to be improved later
    @macobo
    macobo committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    2ddb651 View commit details
    Browse the repository at this point in the history

  2. Remove nanoid package 

    Turns out it was sort of already rolled into this package
    @macobo
    macobo committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    480aa62 View commit details
    Browse the repository at this point in the history

  3. Rename a const

    @macobo
    macobo committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    30cde30 View commit details
    Browse the repository at this point in the history