Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for project_api_key. #32

Merged
merged 3 commits into from
May 18, 2021
Merged

Add support for project_api_key. #32

merged 3 commits into from
May 18, 2021

Conversation

neilkakkar
Copy link
Collaborator

@neilkakkar neilkakkar commented May 18, 2021 •
edited
Loading

Fixes #31

This doesn't remove api_key yet, but supports both project_api_key and api_key.

@neilkakkar neilkakkar requested a review from Twixes May 18, 2021 13:10
mariusandra
mariusandra approved these changes May 18, 2021
View reviewed changes
Copy link
Contributor

@mariusandra mariusandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Twixes Twixes mentioned this pull request May 18, 2021
Open
Twixes
Twixes approved these changes May 18, 2021
View reviewed changes
Copy link
Collaborator

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should fix the reported issue, though still not great how we recommend the new param to users, but internally confusingly use the old one. Created #33 to keep track of this.

@Twixes Twixes merged commit fd92502 into master May 18, 2021
@Twixes Twixes deleted the projectapikey branch May 18, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariusandra mariusandra mariusandra approved these changes

@Twixes Twixes Twixes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

posthog.project_api_key doesn't work
3 participants
@neilkakkar @mariusandra @Twixes