fix(docs): brotli is required on all platforms #3925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous fix in PostHog#3870 suggested that `brotli` was only required on ARM. It's called in `./bin/start` so we need it on all architectures.
👷 Deploy request for posthog accepted.
|
Twixes
approved these changes
Oct 4, 2022
There was a problem hiding this comment.
Sorry for the late review, somehow this got lost in the queue! This is some good clarification.
To make this a bit more accurate, I moved the brotli part to the "Prepare plugin server" section, where it's most relevant. Also did some formatting fixes. Thanks for the contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The previous fix in #3870 suggested that
brotliwas only required on ARM. It's called in./bin/startso we need it on all architectures.I've added made a new paragraph for
brotli, after the platform specificpipinstructions.Checklist