Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to authenticate based on the cloud account #8180

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

MarconLP
Copy link
Member

@MarconLP MarconLP commented Apr 4, 2024

Changes

2024-04-04 at 02 10 20

related #5847

replaces this PR: #7159

Copy link

vercel bot commented Apr 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog ❌ Failed (Inspect) Apr 4, 2024 0:27am

@MarconLP
Copy link
Member Author

MarconLP commented Apr 4, 2024

todos:

@corywatilo
Copy link
Collaborator

corywatilo commented Apr 4, 2024

I ran through a bunch of use cases to test. Not sure if testing on localhost produces the same results as being on posthog.com (same domain?), but here's what I tested:

✅ Creating a new community account (while signed into Cloud)

Linking an existing Cloud and community account that use the same email edit: found this referencing a migration

  • Got error: Email is taken
  • Expected: Links accounts with matching email

❌ Updating email address on Cloud

  • When updating on Cloud, the new email isn't reflected in the community account

❌ Signing into community when also not signed into Cloud

  • After authing on Cloud, it 404s on the authorize redirect:
    image

❌ Being automatically signed into the community when signed into Cloud

  • Expected: When signed into Cloud, visiting the community, and clicking the login button, I should be signed in immediately instead of seeing the Cloud auth screen again

But most importantly, this misses the ultimate goal of intentionally having separate emails for Cloud and community logins and letting users link them. When they leave a job, we want them to be able to take their community account with them. The association between the Cloud and community user will need to be broken, but they should be able to use their community account independently and link it to another Cloud account in the future.

You may also want to link multiple Cloud accounts in the future, as well.

We had originally talked about auth0, which has a plugin for Strapi and would be nice so people can connect their community account with Github (or others). What's the context for going this route instead?

@MarconLP
Copy link
Member Author

MarconLP commented Apr 5, 2024

But most importantly, this misses the ultimate goal of intentionally having separate emails for Cloud and community logins and letting users link them.

The idea of support was using their cloud account on the forum as well, so we can generate login-as-user and session replay links. Essentially removing the difference between an in-app ticket and a community question.

Should we suggest they add a backup email they can use to reset their password to the community if their primary email is deactivated

Currently most community accounts use the same company email they use for the cloud account as well. We would need to ask users for their personal email when logging into the forum for the first time and eventually move the community account to that cloud account as well when using a different cloud account.

You may also want to link multiple Cloud accounts in the future, as well.

In what cases would you need to link multiple cloud accounts? From the support-side we intentionally do not want multiple accounts connected.

When they leave a job, we want them to be able to take their community account with them. The association between the Cloud and community user will need to be broken, but they should be able to use their community account independently and link it to another Cloud account in the future.

I don't think we need to break the Cloud <> Forum account connection, instead they should transfer their community account to another cloud instance. We can do this manually right now, but what would an automated transfer look like?

We ask for their personal email when logging into the forum for the first time. If the community account exists already we link them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants