Fix: Better client info replacement #8423
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In many places in code snippets,
<ph_project_api_key>
and<ph_client_api_host>
aren't being replaced. There seems to be two reasons for this:<ph_project_api_key>
is part of a larger string.<ph_project_api_key>
is being split in 3 tokens and not matching the check.This fixes both these issues. Some feedback requested:
replaceClientApiInfo
function is two loops which could be problematic.