Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security ownership #8471

Merged
merged 3 commits into from
May 21, 2024
Merged

Security ownership #8471

merged 3 commits into from
May 21, 2024

Conversation

tiina303
Copy link
Contributor

Changes

There's an effort to have owners for everything https://posthog.slack.com/archives/C017WDX3BFZ/p1715715289879719
I heard Ben is doing Security and killing at it https://posthog.slack.com/archives/C068NGHEUSG/p1715860864638279

Checklist

  • Words are spelled using American English
  • Titles are in sentence case
  • Feature names are in sentence case too
  • Use relative URLs for internal links
  • If I moved a page, I added a redirect in vercel.json
  • Remove this template if you're not going to fill it out!

Article checklist

  • I've added (at least) 3-5 internal links to this new article
  • I've added keywords for this page to the rank tracker in Ahrefs
  • I've checked the preview build of the article
  • The date on the article is today's date
  • I've added this to the relevant "Tutorials and guides" docs page (if applicable)

Useful resources

Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog ✅ Ready (Inspect) Visit Preview May 21, 2024 11:46am

Co-authored-by: Ben White <ben@posthog.com>
@@ -51,6 +51,7 @@ You can also view the list [directly in GitHub](https://github.com/PostHog/posth
| Replay | [Team Replay][Team Replay] | <span class="lemon-tag gh-tag">feature/replay</span> |
| Retention | [Team Product Analytics][Team Product Analytics] | <span class="lemon-tag gh-tag">feature/retention</span> |
| Saved Insights | [Team Product Analytics][Team Product Analytics] | <span class="lemon-tag gh-tag">feature/saved-insights</span> |
| Security | [@benjackwhite][@benjackwhite] is a good reference person but it is every team's job to consider and react to security issues | <span class="lemon-tag gh-tag">feature/security</span> |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Security | [@benjackwhite][@benjackwhite] is a good reference person but it is every team's job to consider and react to security issues | <span class="lemon-tag gh-tag">feature/security</span> |
| Security | [@benjackwhite][@benjackwhite] is a good reference person but it is every teams job to consider and react to security issues | <span class="lemon-tag gh-tag">feature/security</span> |

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't that what @pauldambra suggested fixing - I edited your above comment btw before committing it

@benjackwhite benjackwhite enabled auto-merge (squash) May 21, 2024 11:42
@benjackwhite benjackwhite merged commit 18f134e into master May 21, 2024
3 checks passed
@benjackwhite benjackwhite deleted the tiina303-patch-8 branch May 21, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants