remove insight router

PostHog · Nov 25, 2021 · e52f474 · e52f474
1 parent c549793
commit e52f474
Show file tree

Hide file tree

Showing 7 changed files with 1 addition and 99 deletions.
diff --git a/frontend/src/scenes/appScenes.ts b/frontend/src/scenes/appScenes.ts
@@ -8,7 +8,6 @@ export const appScenes: Record<Scene, () => any> = {
     [Scene.Dashboards]: () => import('./dashboard/Dashboards'),
     [Scene.Dashboard]: () => import('./dashboard/Dashboard'),
     [Scene.Insight]: () => import('./insights/Insight'),
-    [Scene.InsightRouter]: () => import('./insights/InsightRouter'),
     [Scene.Cohorts]: () => import('./cohorts/Cohorts'),
     [Scene.Events]: () => import('./events/Events'),
     [Scene.Actions]: () => import('./actions/ActionsTable'),

diff --git a/frontend/src/scenes/insights/InsightRouter.tsx b/frontend/src/scenes/insights/InsightRouter.tsx
diff --git a/frontend/src/scenes/insights/insightRouterLogic.ts b/frontend/src/scenes/insights/insightRouterLogic.ts
diff --git a/frontend/src/scenes/sceneLogic.ts b/frontend/src/scenes/sceneLogic.ts
@@ -16,7 +16,6 @@ import { organizationLogic } from './organizationLogic'
 
 /** Mapping of some scenes that aren't directly accessible from the sidebar to ones that are - for the sidebar. */
 const sceneNavAlias: Partial<Record<Scene, Scene>> = {
-    [Scene.InsightRouter]: Scene.Insight,
     [Scene.Action]: Scene.Events,
     [Scene.Actions]: Scene.Events,
     [Scene.EventStats]: Scene.Events,

diff --git a/frontend/src/scenes/sceneTypes.ts b/frontend/src/scenes/sceneTypes.ts
@@ -9,7 +9,6 @@ export enum Scene {
     Dashboards = 'Dashboards',
     Dashboard = 'Dashboard',
     Insight = 'Insight',
-    InsightRouter = 'InsightRouter',
     Cohorts = 'Cohorts',
     Events = 'Events',
     EventStats = 'EventsVolumeTable',

diff --git a/frontend/src/scenes/scenes.ts b/frontend/src/scenes/scenes.ts
@@ -38,10 +38,6 @@ export const sceneConfigurations: Partial<Record<Scene, SceneConfig>> = {
         projectBased: true,
         name: 'Insights',
     },
-    [Scene.InsightRouter]: {
-        projectBased: true,
-        name: 'Insights',
-    },
     [Scene.Cohorts]: {
         projectBased: true,
         name: 'Cohorts',
@@ -178,6 +174,7 @@ export const sceneConfigurations: Partial<Record<Scene, SceneConfig>> = {
 
 export const redirects: Record<string, string | ((params: Params) => string)> = {
     '/': urls.savedInsights(),
+    '/i/:id': ({ id }) => urls.insightView(id),
     '/saved_insights': urls.savedInsights(),
     '/dashboards': urls.dashboards(),
     '/plugins': urls.plugins(),
@@ -194,7 +191,6 @@ export const routes: Record<string, Scene> = {
     [urls.insightEdit(':shortId' as InsightShortId)]: Scene.Insight,
     [urls.insightView(':shortId' as InsightShortId)]: Scene.Insight,
     [urls.savedInsights()]: Scene.SavedInsights,
-    [urls.insightRouter(':shortId')]: Scene.InsightRouter,
     [urls.actions()]: Scene.Actions,
     [urls.eventStats()]: Scene.EventStats,
     [urls.eventPropertyStats()]: Scene.EventPropertyStats,

diff --git a/frontend/src/scenes/urls.ts b/frontend/src/scenes/urls.ts
@@ -14,7 +14,6 @@ export const urls = {
     eventPropertyStats: () => '/events/properties',
     events: () => '/events',
     insightNew: (filters?: Partial<FilterType>) => `/insights/new${filters ? combineUrl('', filters).search : ''}`,
-    insightRouter: (id: string) => `/i/${id}`,
     insightEdit: (id: InsightShortId, filters?: Partial<FilterType>) =>
         `/insights/${id}/edit${filters ? combineUrl('', filters).search : ''}`,
     insightView: (id: InsightShortId, filters?: Partial<FilterType>) =>