Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order everything by timestamp rather than ID #421

Closed
6 tasks
timgl opened this issue Mar 31, 2020 · 0 comments
Closed
6 tasks

Order everything by timestamp rather than ID #421

timgl opened this issue Mar 31, 2020 · 0 comments
Assignees

Comments

@timgl
Copy link
Collaborator

timgl commented Mar 31, 2020

The /batch api allows users to give us a specific timestamp. That means the ordering of the events by ID will fall down, as you could insert events out of order.

Places where we order by ID

  • action.py
  • event.py
  • funnel.py
  • paths.py
  • models.py (filter_by_action and query_db_by_action)
  • Possibly some other places

I think this also means we have to create an index on timestamp to make sure this stays fast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants