Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Insights History #6478

Closed
Twixes opened this issue Oct 15, 2021 · 2 comments
Closed

Remove Insights History #6478

Twixes opened this issue Oct 15, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@Twixes
Copy link
Collaborator

Twixes commented Oct 15, 2021

Is your feature request related to a problem?

Well, actually this is removal of a feature. We currently have something called "History" on the new insight screen. It shows all insights that were calculated, drafts AND saved ones. But it just isn't useful – it's way too noisy. Seeing that it's used by just ~2% of active users of Insights (funnel), I think it's more confusing than valuable.

Describe the solution you'd like

For users with Saved Insights rolled out, let's make the History button non-functional, adding a tooltip pointing to Saved Insights as a better way to view a list of insights. When Saved Insights gets un-feature-flagged, we'll be able to remove History from the code base as well.

CC @paolodamico @clarkus

Additional context

This can be closed with History removal: #5551

Thank you for your feature request – we love each and every one!

@Twixes Twixes added the enhancement New feature or request label Oct 15, 2021
@Twixes Twixes changed the title Remove insights history Remove Insights History Oct 15, 2021
@mariusandra
Copy link
Collaborator

💯 , it's been causing some bugs recently (possibly clearing saved filters on dashboard items, yet there was another new bug there as well) and its existence requires workarounds in otherwise smooth looking code.

More support for removing it here: #5747 (comment)

That said, I wouldn't disrupt things more now and remove it once we launch saved insights.

@Twixes
Copy link
Collaborator Author

Twixes commented Nov 11, 2021

Done!

@Twixes Twixes closed this as completed Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants