Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No history on saved insights #6510

Merged
merged 2 commits into from
Oct 18, 2021
Merged

No history on saved insights #6510

merged 2 commits into from
Oct 18, 2021

Conversation

paolodamico
Copy link
Contributor

Changes

Removes the insight history button when the saved insights flag is enabled in preparation for #6478. Other miscellaneous fixes.

How did you test this code?

  • Manually enabled and disabled the feature flag to make sure the button appeared when relevant.

@timgl timgl temporarily deployed to posthog-pr-6510 October 18, 2021 11:48 Inactive
Twixes
Twixes approved these changes Oct 18, 2021
View reviewed changes
Copy link
Collaborator

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@paolodamico paolodamico merged commit ff74653 into master Oct 18, 2021
@paolodamico paolodamico deleted the no-history-with-saved-insights branch October 18, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Twixes Twixes Twixes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paolodamico @Twixes @timgl