feat(debugging): automatically comment SQL queries #10433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new dependency: sqlcommenter, which automatically appends comments to sql queries generated by django. See more documentation at https://google.github.io/sqlcommenter/python/django/#0
|
In the previous PR we ended up implementing our own middleware inspired by the one you are proposing to allow further customisations (redact PII, etc...) but also this solution looks fine for me. |
guidoiaquinti
approved these changes
Jun 23, 2022
|
Yep - this isn't ideal but also extremely low effort win. :) |
|
Note for release: Instrumentation improvement: We now automatically comment all SQL queries generated by posthog with tags. This helps track down performance issues on self-hosted instances. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new dependency: sqlcommenter, which automatically appends
comments to sql queries generated by django.
See more documentation at https://google.github.io/sqlcommenter/python/django/#0
Release notes: Our postgres queries are now automatically commented with endpoints queries originate from. This will make it easier for self-hosted users to report and debug bugs or performance-related issues.