Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up people load by not loading events #1056

Merged
merged 3 commits into from
Jun 23, 2020
Merged

Speed up people load by not loading events #1056

merged 3 commits into from
Jun 23, 2020

Conversation

timgl
Copy link
Collaborator

@timgl timgl commented Jun 19, 2020

Changes

  • Based on @EDsCODE changes to the people view on trends, we were still loading the latest event for each user despite not displaying them. This remove that and takes query time locally from 4 seconds to 1.2.

Checklist

  • All querysets/queries filter by Team (if applicable)
  • Backend tests (if applicable)
  • Cypress E2E tests (if applicable)

@timgl timgl requested a review from EDsCODE June 19, 2020 09:19
@timgl timgl temporarily deployed to posthog-speed-up-people-jt0bgt June 19, 2020 09:20 Inactive
EDsCODE
EDsCODE requested changes Jun 22, 2020
View reviewed changes
Copy link
Member

@EDsCODE EDsCODE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small line below which is also the source of the test errors

posthog/api/person.py Outdated
"name",
"distinct_ids",
"properties",
"last_event",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field isn't handled anymore. Should be removed otherwise endpoint errors

@timgl timgl temporarily deployed to posthog-speed-up-people-jt0bgt June 22, 2020 14:13 Inactive
@timgl timgl merged commit 11720c3 into master Jun 23, 2020
@timgl timgl deleted the speed-up-people-load branch June 23, 2020 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EDsCODE EDsCODE EDsCODE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timgl @EDsCODE