Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LZ-String compression #1058

Merged
merged 5 commits into from
Jul 6, 2020
Merged

LZ-String compression #1058

merged 5 commits into from
Jul 6, 2020

Conversation

mariusandra
Copy link
Collaborator

@mariusandra mariusandra commented Jun 19, 2020

Changes

This is a counterpart to the PR in the posthog-js repo (that I still need to update a bit).

With this in, posthog-js payloads should go down in size up to 4x. (64kb -> 16kb)

Checklist

  • All querysets/queries filter by Team (if applicable)
  • Backend tests (if applicable)
  • Cypress E2E tests (if applicable)

@timgl timgl temporarily deployed to posthog-js-payload-comp-6irgod June 19, 2020 12:52 Inactive
@mariusandra mariusandra changed the title LZ-String compression [WIP] LZ-String compression Jul 2, 2020
@mariusandra mariusandra requested a review from EDsCODE July 2, 2020 13:37
@mariusandra mariusandra marked this pull request as ready for review July 2, 2020 13:37
@mariusandra
Copy link
Collaborator Author

Ah, some typing errors to fix still. Should be done in a few min.

@mariusandra mariusandra requested a review from timgl July 6, 2020 09:04
Copy link
Collaborator

@timgl timgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This side looks good!

@timgl timgl merged commit e3aac13 into master Jul 6, 2020
@timgl timgl deleted the js-payload-compression branch July 6, 2020 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants