Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1050 breakdown person props #1070

Merged
merged 6 commits into from
Jun 23, 2020
Merged

1050 breakdown person props #1070

merged 6 commits into from
Jun 23, 2020

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Jun 23, 2020

Changes

Todo:

  • add test
  • check type safety on optionals

Checklist

  • All querysets/queries filter by Team (if applicable)
  • Backend tests (if applicable)
  • Cypress E2E tests (if applicable)

@timgl timgl temporarily deployed to posthog-1050-breakdown--guvddo June 23, 2020 00:30 Inactive
@EDsCODE EDsCODE marked this pull request as ready for review June 23, 2020 13:26
@timgl timgl temporarily deployed to posthog-1050-breakdown--guvddo June 23, 2020 13:26 Inactive
@EDsCODE EDsCODE requested a review from timgl June 23, 2020 13:34
@timgl
Copy link
Collaborator

timgl commented Jun 23, 2020

Nice!

@timgl timgl merged commit d71805b into master Jun 23, 2020
@timgl timgl deleted the 1050-breakdown-person-props branch June 23, 2020 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timgl timgl Awaiting requested review from timgl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EDsCODE @timgl