-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: nuke protobuf fully #10932
chore: nuke protobuf fully #10932
Conversation
This does not do what it says it does:
Schema snapshots are also unupdated? |
Any preference between adding that to this pr vs updating the title to "... part 1" & following up
Shouldn't there be a failing test? |
Ask for forgiveness, not permission.
Up to you to check - in general schema changes like this should probably result in a snapshot changing. You can verify this locally - maybe this one doesn't? |
Rebase to fix the plugin server test fail |
Nuke protobuf fully part 2
Problem
This is live for a while on cloud and since 1.36.0 for self-hosted (63c783f).
Changes
Note that I nuked the code for 0004 async migration (other than the requirements and precheck part (which helps fail the upgrade if someone is trying to upgrade past it)). I believe rather than wasting time adopting the code that will be never ran (because the idea of async migrations was that we also update the code so that new installs wouldn't need to run them). Hence it would be a waste of everyone's time and resources to keep fixing the code and tests.
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?
Ran PostHog locally seemed to work fine and saw events coming in.