Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sessions load #1221

Merged
merged 3 commits into from
Jul 16, 2020
Merged

Make sessions load #1221

merged 3 commits into from
Jul 16, 2020

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Jul 15, 2020

Changes

  • original session implementation was causing events to evaluate when unneeded. removed this
  • the query is still due for optimizations but this should atleast make things load properly

Checklist

  • All querysets/queries filter by Team (if applicable)
  • Backend tests (if applicable)
  • Cypress E2E tests (if applicable)

@EDsCODE EDsCODE requested a review from mariusandra July 15, 2020 18:14
@timgl timgl temporarily deployed to posthog-sessions-hang-u-xlqy4f July 15, 2020 18:15 Inactive
@timgl timgl temporarily deployed to posthog-sessions-hang-u-xlqy4f July 15, 2020 18:25 Inactive
@mariusandra mariusandra temporarily deployed to posthog-sessions-hang-u-xlqy4f July 16, 2020 11:45 Inactive
@mariusandra
Copy link
Collaborator

Works great! I added a ?. fix for a line that caused my sessions page to crash.

@EDsCODE EDsCODE merged commit 932e200 into master Jul 16, 2020
@EDsCODE EDsCODE deleted the sessions-hang-up branch July 16, 2020 13:12
@EDsCODE EDsCODE mentioned this pull request Jul 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariusandra mariusandra mariusandra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EDsCODE @mariusandra @timgl