enhanced ctrl + click new tab opening feature #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks for creating this PR! I think the actual issue is with the Link.js component, not the sidebar. I suggest adding something to the onClick listener in that component that just returns if ctrl (or command in the case of mac) is held down |
|
Hey @timgl my bad didn't realize it could have been that minor change. |
timgl
reviewed
Jul 20, 2020
frontend/src/lib/components/Link.js
Outdated
| @@ -7,6 +7,10 @@ export function Link({ to, preventClick = false, ...props }) { | |||
| href={to || '#'} | |||
| {...props} | |||
| onClick={(event) => { | |||
| if (event.ctrlKey) { | |||
There was a problem hiding this comment.
Could you do if (event.metaKey || event.ctrlKey) so that it works on mac as well?
There was a problem hiding this comment.
sure will add it right away
frontend/src/lib/components/Link.js
Outdated
| @@ -7,6 +7,10 @@ export function Link({ to, preventClick = false, ...props }) { | |||
| href={to || '#'} | |||
| {...props} | |||
| onClick={(event) => { | |||
| if (event.ctrlKey) { | |||
| window.open(to, '_blank') | |||
There was a problem hiding this comment.
Could you do return window.open(to, '_blank')? Now if you open it in a new tab it'll also load the page in the current tab
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
modified collapseSidebar function and added the url parameter so if any sidebar is being clicked the user would be ab
open a new tab upon have ctrl button pressed.
Not sure if any specific contributing guidelines are there do let me know incase I miss out anything.
Reference to issue #1187 , #850
code review: @timgl @mariusandra
checklist