feat(insights): add area chart (closes #7372) #12869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @thmsobrmlr! 👋 |
thmsobrmlr
force-pushed
the
area-charts
branch
2 times, most recently
from
8866b4d
to
b94b61d
Compare
thmsobrmlr
force-pushed
the
area-charts
branch
from
699577e
to
c16d22c
Compare
thmsobrmlr
changed the title
2 tasks
|
picked! |
neilkakkar
pushed a commit
that referenced
this pull request
Nov 30, 2022
* add area chart display type * refactor(line-graph): use chartjs scriptable to dash lines for incomplete data * add initial implementation of stacked area chart * implement missing data for area charts * fix icon * add storybook examples * disable compare to previous for area charts * improve comments * refactor show compare filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Users have been asking for an area chart. The main use case for this when you want to see the composition of a metric, while also having the total value as reference e.g. breakdown of revenue by customer over time.
Changes
<LineChart />component to use line segments instead of splitting the data into two parts for incomplete dataHow did you test this code?