Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use pnpm to manage dependencies (closes #12635) #13190

Merged
merged 46 commits into from
Dec 12, 2022
Merged

Conversation

thmsobrmlr
Copy link
Contributor

@thmsobrmlr thmsobrmlr commented Dec 7, 2022

Release notes: Let's make sure to include Jacob here.

Continuing the excellent work of @jacobwgillespie at #12635 here, since apparently GitHub does not allow edits by maintainers if the repo and the fork are located in organization accounts.

Associated Handbook update here: PostHog/posthog.com#4865

Problem

Followup from #12520 (see there for more context), this PR replaces Yarn 1 with pnpm. Yarn 1 is semi-unmaintained and has caused issues in docker build.

Changes

This PR switches to use pnpm instead of yarn. The highlights are:

  • All yarn commands are updated to their pnpm equivalents
  • GitHub Actions workflows and the Dockerfile use pnpm now
  • Some additional dependencies have been added to package.json if they previously were only available due to hoisting.

How did you test this code?

Installed locally + ran docker build. Will need CI to run the tests.

@jacobwgillespie
Copy link
Contributor

Nice, thanks for picking this up, I haven't had many spare cycles to finish the PR lately 🙌

Copy link
Collaborator

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works!

.github/workflows/ci-frontend.yml Outdated Show resolved Hide resolved
frontend/src/lib/components/Popup/Popup.tsx Outdated Show resolved Hide resolved
@thmsobrmlr thmsobrmlr merged commit 4a30e78 into master Dec 12, 2022
@thmsobrmlr thmsobrmlr deleted the pr-12635-pnpm branch December 12, 2022 09:28
@thmsobrmlr
Copy link
Contributor Author

Nice, thanks for picking this up, I haven't had many spare cycles to finish the PR lately 🙌

Thanks for your awsome work at #12635, @jacobwgillespie! We probably wouldn't have made the switch yet without your contribution and are really happy to have it. I'll make sure to include you in the next release notes :)

@thmsobrmlr thmsobrmlr added the highlight ⭐ Release highlight label Dec 12, 2022
@jacobwgillespie
Copy link
Contributor

Awesome, happy to see it merge! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
highlight ⭐ Release highlight
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants