chore(ci/cd): switch deployment action #13545
Conversation
guidoiaquinti
force-pushed
the
switch_deployment
branch
from
9db4085
to
c8e0962
Compare
| name: E2E CI | ||
|
|
||
| on: | ||
| pull_request: | ||
| push: |
There was a problem hiding this comment.
We do not need to run this on master anymore
There was a problem hiding this comment.
I think it's still sensible to run the tests on master - two branches may pass tests individually, but when both merged they may cause a failure
There was a problem hiding this comment.
I think it's still sensible to run the tests on master - two branches may pass tests individually, but when both merged they may cause a failure
I agree and I'm 👍 to change this. I just want to point out that this PR didn't change the previous behaviour as the Cypress E2E tests matrix was only running on non-master
There was a problem hiding this comment.
Ahhh ok sure, makes sense then 👍
There was a problem hiding this comment.
A CI failure will anyway not block the deployment, is it ok for you?
| run: echo "specs=$(ls cypress/e2e/* | jq --slurp --raw-input -c 'split("\n")[:-1] | _nwise(3) | join("\n")' | jq --slurp -c .)" >> $GITHUB_OUTPUT | ||
|
|
||
| cypress: | ||
| name: Cypress E2E tests (${{ strategy.job-index }}) | ||
| if: ${{ github.ref != 'refs/heads/master' }} # Don't run on master, we only care about node_modules cache |
There was a problem hiding this comment.
not necessary anymore as we do not run on master
| @@ -13,7 +13,6 @@ on: | |||
| push: | |||
| branches: | |||
| - master | |||
| - main | |||
There was a problem hiding this comment.
This is coming from a great suggestion from @hazzadous: as we only have branch protection enabled on master, let's do not use main till we officially switch to it.
| @@ -118,3 +117,23 @@ jobs: | |||
| # the posthog-cloud code we've checked out. | |||
| build-args: | | |||
| BASE_IMAGE=posthog/posthog:latest | |||
|
|
|||
| - name: Trigger PostHog Cloud deployment | |||
| # TODO: switch to https://github.com/marketplace/actions/repository-dispatch | |||
There was a problem hiding this comment.
I didn't change the action directly in this PR as there's likely a little dance that needs to happen between this repo and posthog-cloud-infra as the action output changes a bit.
guidoiaquinti
assigned hazzadous, ellie and danielxnj and unassigned hazzadous, ellie and danielxnj
|
Sorry @hazzadous but I had to fix a merge conflict. The conflict was a 1 liner |
Changes
remove all the container build logic that was present in
.github/workflows/ci-e2e.ymlas we now have dedicated workflows for it.move the
Trigger PostHog Cloud deploymentstep from.github/workflows/ci-e2e.ymlto.github/workflows/container-images-cd.yml.make the E2E CI Cypress tests pull the container image from the GitHub container registry instead of rebuilding it.
How did you test this code?
CI should be ✅ for
.github/workflows/ci-e2e.yml..github/workflows/container-images-cd.ymlonly runs onmasterso I didn't test it but it's more or less a copy paste of what we had already.