Enhance and optimize PR GitHub workflows #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twixes
changed the title
|
This will make PR checks faster and more comprehensive, but you'll need to update "required status checks" in repo settings. @timgl I think all besides Cypress should be required. |
timgl
reviewed
Aug 10, 2020
requirements.txt
Outdated
| @@ -23,6 +23,7 @@ django-redis==4.12.1 | |||
| django-statsd==2.5.2 | |||
| djangorestframework==3.11.0 | |||
| djangorestframework-csv==2.1.0 | |||
| freezegun==0.3.15 | |||
There was a problem hiding this comment.
don't thinik that's supposed to be in here?
There was a problem hiding this comment.
Hm, wouldn't be a problem but yeah, since only tests need freezegun and they're run with prod requirements.txt only, I just put it into the GH workflow.
This reverts commit 460e3942d10194e9f46c8a2196ebd9ecc1f23c6f.
Twixes
force-pushed
the
improve-github-workflows
branch
from
22e92f9
to
d1cebd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This improves GitHub workflow naming and separation, uses parallel jobs, updates ESLint linting, and adds prettier plus black checks. Also makes use of GitHub check annotations.