Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance version notice #1386

Merged
merged 3 commits into from
Aug 10, 2020
Merged

Enhance version notice #1386

merged 3 commits into from
Aug 10, 2020

Conversation

Twixes
Copy link
Collaborator

@Twixes Twixes commented Aug 7, 2020

Changes

This makes it clear which version is the latest one even if https://update.posthog.com/changelog hasn't been updated.

Version behind
Version behind

Version up to date
Version up to date

'This is the latest one.'
) : (
<>
The latest one is <b>{latestVersion}</b>.
Copy link
Collaborator

@timgl timgl Aug 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The newest version is"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe

You're on PostHog 1.2.3. The newest version is 1.2.4.
You're on PostHog 1.2.4. This is the newest version.

instead?

@timgl timgl temporarily deployed to posthog-version-notice-it7bq3t August 7, 2020 13:49 Inactive
@timgl timgl temporarily deployed to posthog-version-notice-it7bq3t August 7, 2020 13:54 Inactive
@timgl timgl temporarily deployed to posthog-version-notice-it7bq3t August 7, 2020 13:55 Inactive
@timgl timgl merged commit 7b9abe4 into master Aug 10, 2020
@timgl timgl deleted the version-notice branch August 10, 2020 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants