New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add enterprise edition and licensing #1390
Conversation
@@ -0,0 +1,36 @@ | |||
The PostHog Enterprise license (the “Enterprise License”) | |||
Copyright (c) 2020 PostHog Inc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jamesefhawkins do you mind checking the changes to the licensing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found two "typos" that could be fixed... and it might be good to run kea-typegen
to get types for the new logic. The rest looks good!
Running it with and without the "ee"
folder worked. However when running without that folder, the /setup/licenses
page would still open when I entered the URL directly. Then it would crash when I tried to use it.
This can absolutely be left for a future PR, but I think we need a way to also split the frontend into the "ee" and "non-ee" parts, possibly moving the /setup/licenses page into a ee/frontend
folder.
@mariusandra Yep agree 100%. I don't quite have the webpack wizardry (and we only have a tiny bit of ee frontend code right now). Added #1395, would love your input |
What's the use case for multiple licenses per team? |
@Twixes You might add a license that expires, or you might add a license that has a higher plan than the one you currently have. It'll be unlikely you'll have multiple licenses active at once, but at least this gives you the history |
Changes
Checklist