Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better posthog-foss syncing #1423

Merged
merged 2 commits into from
Aug 20, 2020
Merged

Better posthog-foss syncing #1423

merged 2 commits into from
Aug 20, 2020

Conversation

ungless
Copy link
Contributor

@ungless ungless commented Aug 13, 2020

Changes

  • this is FAR better way of syncing posthog/posthog with posthog/posthog-foss.
  • this happens on push to master, unlike the previous approach which ran on cron

Needed for merge

@ungless ungless added enhancement New feature or request Dev Experience labels Aug 13, 2020
@ungless ungless changed the title Create posthog-foss syncing Better posthog-foss syncing Aug 13, 2020
@timgl timgl temporarily deployed to posthog-add-sync-workfl-9y9s4y August 13, 2020 14:17 Inactive
@ungless
Copy link
Contributor Author

ungless commented Aug 13, 2020

NB: check is failing due to missing secrets.

@timgl
Copy link
Collaborator

timgl commented Aug 14, 2020

I don't think this action should happen on push on every branch, but just on master right? I've added the secret to this repo

@Twixes Twixes temporarily deployed to posthog-add-sync-workfl-9y9s4y August 16, 2020 15:43 Inactive
@Twixes
Copy link
Collaborator

Twixes commented Aug 16, 2020

Should now work that way @timgl.

@timgl
Copy link
Collaborator

timgl commented Aug 18, 2020

@ungless Ready to merge? Not sure how to test this but might not really matter

@ungless
Copy link
Contributor Author

ungless commented Aug 18, 2020

All OK as long as all actions are disabled in https://github.com/posthog/posthog-foss -- otherwise actions from this repo will trigger in posthog-foss when pushed.

@Twixes
Copy link
Collaborator

Twixes commented Aug 20, 2020

I'll merge this in and we'll see how it works.

@Twixes Twixes merged commit 6795635 into master Aug 20, 2020
@Twixes Twixes deleted the add-sync-workflow branch August 20, 2020 13:30
@Twixes
Copy link
Collaborator

Twixes commented Aug 20, 2020

Works nicely! @ungless

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants