Updates Action without ignoring created_by #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgl
reviewed
Aug 17, 2020
posthog/api/action.py
Outdated
| @@ -91,6 +91,17 @@ class Meta: | |||
| "created_by", | |||
| ] | |||
|
|
|||
| def update(self, instance, validated_data): | |||
There was a problem hiding this comment.
Hm interesting, though I think this will end up creating a lot of ongoing work for us, as each time we add a field we have to remember to add it here too.
Would it be easier to just delete created_by on this line?
There was a problem hiding this comment.
I don't have a link to the line you sent
but a del request.data['created_by'] somewhere before the update in https://github.com/PostHog/posthog/blob/master/posthog/api/action.py#L167 works as well
timgl
approved these changes
Aug 17, 2020
Check for created_by in data before deleting it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Please describe.
If this affects the front-end, include screenshots.
Checklist