Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve heatmap count display #1459

Merged
merged 5 commits into from
Aug 18, 2020
Merged

Improve heatmap count display #1459

merged 5 commits into from
Aug 18, 2020

Conversation

mariusandra
Copy link
Collaborator

Changes

Before:

Screenshot 2020-08-18 at 16 32 38

After (artificially inflating the numbers):

Screenshot 2020-08-18 at 16 55 50

After (no inflation):

image

Checklist

  • All querysets/queries filter by Team (if this PR affects any querysets/queries)
  • Backend tests (if this PR affects the backend)
  • Cypress E2E tests (if this PR affects the front and/or backend)

@timgl timgl temporarily deployed to posthog-1374-toolbar-he-8yeu3k August 18, 2020 15:00 Inactive
@Twixes Twixes temporarily deployed to posthog-1374-toolbar-he-8yeu3k August 18, 2020 15:26 Inactive
@Twixes Twixes temporarily deployed to posthog-1374-toolbar-he-8yeu3k August 18, 2020 17:12 Inactive
@Twixes Twixes temporarily deployed to posthog-1374-toolbar-he-8yeu3k August 18, 2020 17:48 Inactive
@Twixes Twixes temporarily deployed to posthog-1374-toolbar-he-8yeu3k August 18, 2020 18:01 Inactive
Twixes
Twixes approved these changes Aug 18, 2020
View reviewed changes
Copy link
Collaborator

@Twixes Twixes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made that humanizeNumber function copied from a 2012 SO thread just a bit more 2020. 😄
PR looks good to me!

@mariusandra
Copy link
Collaborator Author

Haha, thanks for that! :)

@mariusandra mariusandra merged commit 1b11605 into master Aug 18, 2020
@mariusandra mariusandra deleted the 1374-toolbar-heatmap-count branch August 18, 2020 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Twixes Twixes Twixes approved these changes

@timgl timgl Awaiting requested review from timgl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Toolbar heatmap "yellow labels" aren't clear
3 participants
@mariusandra @Twixes @timgl