Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(trends): Allow breakdown on aggregated Trends with a formula #14675

Merged
merged 8 commits into from
Mar 10, 2023

Conversation

Twixes
Copy link
Collaborator

@Twixes Twixes commented Mar 10, 2023

Changes

Resolves #10327, resolves #8165, resolves #6602. Also, ZEN-1594.
Until now, users have been seeing an error when trying to use a formula AND a breakdown on Trends insights using aggregated display types (i.e. non-time-series, like the pie chart). This should now work properly.

How did you test this code?

Added a new query test, ensuring it failed before.

Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inconsistent alias? 🤯

:shipit:

@Twixes Twixes merged commit 45ea6b0 into master Mar 10, 2023
@Twixes Twixes deleted the fix-aggregated-formula branch March 10, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants