Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate insight api #1498

Merged
merged 104 commits into from
Sep 1, 2020
Merged

Consolidate insight api #1498

merged 104 commits into from
Sep 1, 2020

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Aug 25, 2020

Changes

Please describe.

  • updates API to use /insight/{entity_type}

If this affects the front-end, include screenshots.

Checklist

  • All querysets/queries filter by Team (if this PR affects any querysets/queries)
  • Backend tests (if this PR affects the backend)
  • Cypress E2E tests (if this PR affects the front and/or backend)

@timgl timgl temporarily deployed to posthog-consolidate-ins-qemfkv August 25, 2020 13:17 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-consolidate-ins-qemfkv August 25, 2020 13:18 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-consolidate-ins-qemfkv August 25, 2020 13:45 Inactive
@EDsCODE EDsCODE requested a review from timgl August 25, 2020 14:21
Copy link
Collaborator

@timgl timgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good and everything works. I am a little concerned about having no tests for the insights endpoint. Worth adding some?

@EDsCODE EDsCODE requested a review from timgl September 1, 2020 13:18
@timgl timgl merged commit c20df29 into master Sep 1, 2020
@timgl timgl deleted the consolidate-insight-api branch September 1, 2020 13:19
macobo added a commit that referenced this pull request Dec 9, 2020
This seems to be dead since #1498
macobo added a commit that referenced this pull request Dec 9, 2020
This seems to be dead since #1498
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants