New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(poe-v2): fix funnels with cohort breakdowns #15457
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious why these snapshots got deleted.
Also, add the poe_v2
decorator to the failing test?
@neilkakkar added the decorator. Unsure why they get deleted 🤔 |
Sorted now - though seems we have some unrelated snapshot changes too |
@@ -269,6 +275,7 @@ def test_funnel_aggregate_by_groups_breakdown_group(self): | |||
@also_test_with_materialized_columns( | |||
group_properties=[(0, "industry")], materialize_only_with_person_on_events=True | |||
) | |||
@also_test_with_person_on_events_v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, I think the sort-of unrelated change is because of the ordering here, materialised one became poe v2 test instead. No biggie though
Fixing the funnels-related tests from #15446