Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix property filtering null values #1546

Merged
merged 1 commit into from
Sep 2, 2020
Merged

Fix property filtering null values #1546

merged 1 commit into from
Sep 2, 2020

Conversation

timgl
Copy link
Collaborator

@timgl timgl commented Sep 1, 2020

Changes

If any property was filtered with not_contains, it ignored any values that were null. For example:

Filtering email does not contain posthog.com wouldn't match {"email": null}, but it should.

Checklist

  • All querysets/queries filter by Team (if this PR affects any querysets/queries)
  • Backend tests (if this PR affects the backend)
  • Cypress E2E tests (if this PR affects the front and/or backend)

@timgl timgl temporarily deployed to posthog-fix-property-fi-sq9zqq September 1, 2020 20:24 Inactive
Twixes
Twixes approved these changes Sep 2, 2020
View reviewed changes
Copy link
Collaborator

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, regex as well.

@Twixes Twixes merged commit ed0bddb into master Sep 2, 2020
@Twixes Twixes deleted the fix-property-filtering-null-values branch September 2, 2020 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Twixes Twixes Twixes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timgl @Twixes