Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add pausing/unpausing buttons to exports list #16050

Merged
merged 2 commits into from
Jun 14, 2023

Conversation

tomasfarias
Copy link
Contributor

@tomasfarias tomasfarias commented Jun 14, 2023

Problem

Users are very limited with what they can do in the Batch Exports UI.

Changes

This adds support for pausing and unpausing batch exports. Also, we add a Status field to the table.

I made the Actions field a flex container to add a Delete button in a follow-up PR.

Here's a demo:

Kooha-2023-06-14-16-19-52

There's a couple of visual bugs you may spot in the demo:

  • The size of the columns changes as the status value changes, maybe there is a way to fix this?
  • The size of the play/unpause button also changes while loading (as the spinner takes up more space?). Would be nice if this also stayed constant.

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

Copy link
Contributor

@hazzadous hazzadous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Perhaps at some point we can add a test for the list page, similar to #16045 assuming that can be merged.

Also the would be great to add to the storybook mocks the appropriate endpoints.

@tomasfarias tomasfarias force-pushed the feat/batch-exports-ui-updates branch 2 times, most recently from 9f8112f to 7e9422a Compare June 14, 2023 16:33
@tomasfarias tomasfarias force-pushed the feat/batch-exports-ui-updates branch from 7e9422a to 6100bdc Compare June 14, 2023 16:42
@tomasfarias tomasfarias marked this pull request as ready for review June 14, 2023 16:58
@tomasfarias tomasfarias merged commit 9d84f0a into master Jun 14, 2023
60 checks passed
@tomasfarias tomasfarias deleted the feat/batch-exports-ui-updates branch June 14, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants