Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "is_simple_flag" to Feature flags #1639

Merged
merged 4 commits into from
Sep 11, 2020
Merged

Add "is_simple_flag" to Feature flags #1639

merged 4 commits into from
Sep 11, 2020

Conversation

timgl
Copy link
Collaborator

@timgl timgl commented Sep 10, 2020 •
edited
Loading

Changes

Add property to API that works if a feature flag is 'simple' (ie you can use it without calling to server) or not

Checklist

  • All querysets/queries filter by Team (if this PR affects any querysets/queries)
  • Backend tests (if this PR affects the backend)
  • Cypress E2E tests (if this PR affects the front and/or backend)

@timgl timgl temporarily deployed to posthog-feature-flags-1fapcxli September 10, 2020 14:42 Inactive
yakkomajuri
yakkomajuri approved these changes Sep 11, 2020
View reviewed changes
Copy link
Contributor

@yakkomajuri yakkomajuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@yakkomajuri yakkomajuri merged commit fe3c8e7 into master Sep 11, 2020
@yakkomajuri yakkomajuri deleted the feature-flags branch September 11, 2020 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yakkomajuri yakkomajuri yakkomajuri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timgl @yakkomajuri