chore: add term signal handler to temporal worker #16496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment it seems that the temporal worker is immediately terminated when the pod is shut down. This is not ideal as it means that any in-flight workflows are not given a chance to complete.
tomasfarias
approved these changes
Jul 11, 2023
added 2 commits
July 11, 2023 15:52
Done 馃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment it seems that the temporal worker is immediately
terminated when the pod is shut down. This is not ideal as it
means that any in-flight workflows are not given a chance to complete.
Problem
Changes
馃憠 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?