Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cached results for funnels #1671

Merged
merged 4 commits into from
Sep 17, 2020
Merged

Use cached results for funnels #1671

merged 4 commits into from
Sep 17, 2020

Conversation

timgl
Copy link
Collaborator

@timgl timgl commented Sep 17, 2020

Changes

Shared dashboards use the cached results to show the data, but we weren't using this for funnels

Checklist

  • All querysets/queries filter by Team (if this PR affects any querysets/queries)
  • Backend tests (if this PR affects the backend)
  • Cypress E2E tests (if this PR affects the front and/or backend)

@timgl timgl requested a review from Twixes September 17, 2020 09:26
@timgl timgl temporarily deployed to posthog-use-cached-resu-nw3moe September 17, 2020 09:27 Inactive
@Twixes Twixes merged commit b175cac into master Sep 17, 2020
@Twixes Twixes deleted the use-cached-results-for-funnels branch September 17, 2020 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Twixes Twixes Awaiting requested review from Twixes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timgl @Twixes