Make production docker-compose.yml generated #1704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @yakkomajuri per emails & Slack |
fuziontech
approved these changes
Sep 23, 2020
docker-compose-yml-gen.py
Outdated
Comment on lines
10
to
15
| def generate_secret_key() -> str: | ||
| """Generate securely random 50 ASCII letters and digits.""" | ||
| return "".join( | ||
| secrets.choice(string.ascii_letters + string.digits) for _ in range(50) | ||
| ) # random 50 ASCII letters and digits | ||
|
|
.gitignore
Outdated
| @@ -27,3 +27,4 @@ yarn-error.log | |||
| yalc.lock | |||
| cypress/screenshots/* | |||
| docker-compose.prod.yml | |||
| docker-compose.yml | |||
There was a problem hiding this comment.
We don't want to ignore docker-compose.yml do we? I feel like we should include a safe fail-safe docker-compose config in case someone doesn't know how to run the script to generate one.
docker-compose-yml-gen.py
Outdated
Comment on lines
18
to
19
| with open("docker-compose.yml", "w") as file: | ||
| yaml.dump( |
There was a problem hiding this comment.
This could just overwrite the prebaked docker-compose.yml that ships with the repo right?
There was a problem hiding this comment.
It'd be a bit more brittle, but it could
|
Echoing @fuziontech here - I'm up for keeping the file and just overwriting it if you run the script |
|
Alright, changed the approach to editing a default |
knubie
added a commit
to knubie/posthog.com
that referenced
this pull request
Jan 28, 2021
This file was removed in PostHog/posthog#1704
yakkomajuri
added a commit
to PostHog/posthog.com
that referenced
this pull request
Feb 5, 2021
* Remove reference to docker-compose.proxy.yml This file was removed in PostHog/posthog#1704 * Remove reference from deploy-docker.md * minor update Co-authored-by: yakkomajuri <yakko.majuri@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This is a proposal to make
docker-compose.ymlconfigurable withdocker-compose-config.py. As various users have various needs (for example some are hosting directly off of theposthogDocker image, while others through a reverse proxy), the included config needs to be edited manually, which isn't really explained. With a guided config generation approach this is all smoother for the deploying user.A downside here is that this requires the external
pyyaml, since YAML suport isn't in the Python stdlib.