1684 allow ip override #1744
Merged
1684 allow ip override #1744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yakkomajuri
approved these changes
Sep 29, 2020
| Person.objects.create(team=self.team, distinct_ids=["asdfasdfasdf"]) | ||
|
|
||
| process_event_ee( | ||
| "asdfasdfasdf", |
There was a problem hiding this comment.
Definitely a nitpick (and not specifically related to this PR), but these "asdfasdfasdf" ids seem to be all over the tests. Probably helpful for newcomers + nicer aesthetically to have them actually be a little more descriptive. You can see it generates confusion because the test test_capture_no_sent_at actually passes "movie played" as the distinct_id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Allow users to pass $ip as a property without it being overridden.
Checklist