Test if any filters exist and if they do make sure there are properties to filter on for decide endpoint #1759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es to filter on for decide endpoint
EDsCODE
reviewed
Sep 29, 2020
posthog/api/feature_flag.py
Outdated
| filters = feature_flag.filters | ||
| if not filters: | ||
| return True | ||
| if not feature_flag.filters.get("properties", []): |
There was a problem hiding this comment.
NIT: filters directly instead of feature_flag.filters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
you can see with this example that the property filters are empty but it is still evaluating
is_simple_flagto be False{'id': 71, 'name': '[Clickhouse] retention endpoint', 'key': 'ch-retention-endpoint', 'rollout_percentage': 100, 'filters': {'properties': []}, 'deleted': False, 'active': True, 'created_by': {'id': 218, 'distinct_id': 'C8UGS3uhn4QTfUiZr1RyqTmtJ31AokcbotSpX2rafCQ', 'first_name': 'Eric', 'email': 'eric@posthog.com'}, 'created_at': '2020-09-28T12:24:55.162765Z', 'is_simple_flag': False}Checklist